Remove 5.x versionadded directives #15518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought the same, but I would prefer we do this after the release of Symfony 6, to reduce merge conflicts, WDYT? |
|
Yes ... but there shouldn't be conflicts, right? Only if we change the contents of these directives, which is extremely rare. But maybe I'm missing something. |
|
We will for example a new bridge in 5.4 will always cause a conflict |
wouterj
approved these changes
Jul 16, 2021
javiereguiluz
force-pushed
the
remove_versionadded
branch
from
fab87a8 to
9859c37
Compare
javiereguiluz
force-pushed
the
remove_versionadded
branch
from
9859c37 to
6aa61a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This process had to be manual because some
versionaddeddirectives contained information that had to be moved to notes or normal paragraphs. Thanks!